[Feature Request] ignore certain parenthesis groups to get thumbnails or metadata
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
Currently metadata or thumbnails use the label, or if a setting is used, the filename, plus the playlist system to get the image/information.
Which is very good, for playlists using filenames directly or indirectly to get scanned.
Anyway for translations using romhacks its easy to get the thumbnails - just keep the original name.
For hacks however, if you did that you wouldn't be able to look at a glance and find the functional difference.
For both cases, if you want the original or another patched version of the game also in the playlist (especially common with hacks) youre in trouble if you keep the original name. You won't be able to tell which is which.
What I'm asking here is essentially something similar to the option to remove () or [] groups from labels that already exists for playlists, but instead of being used for labels, I want it to be used in the strings that look up thumbnails in the server and cache to download and lookup images, or the metadata lookup in explore.
Since no intro redump dont use [] in filenames you could have it be a toggle instead of a option (indeed I feel thats best because I dont know of a dump group that uses [] but dont uses () too.). If you want to be safer {} exists too but I find those parentheses slightly ugly.
They'd be used like this by the user only:
Shin Megami Tensei (Japan) [Translation by Aeon Genesis, map hack]
And the text in between could be anything. The only thing that needs to happen is a setting, and removing [] groups (or even just the last) and regularize spaces (or if just removing the last, trim the last space before '.') before the string is used in those 3 functions.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing playlist setting that removes parenthesis groups from labels, then trace the thumbnail server/cache lookup and the metadata lookup in Explore. Add a user setting for removing bracketed groups and normalizing spaces, and verify that the resulting lookup strings work for thumbnails and metadata without changing displayed labels.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100