libretro / libretro/RetroArch

Video rotation oddities under Metal.

Open
#19,142 85 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Is there an existing issue for this?
  • This is a bug in RetroArch frontend
  • I have searched the existing issues
Description

After 2d37811, aspect ratio is properly applied for a given rotation but the orientation never changes. This applies to all shaders.

I can’t upload images to GitHub for some reason. Please look here: https://imgur.com/a/nXOrkEB

ba28fae fixed the rotation issue on Golden Gate but we need to verify it works in Tahoe and Sonoma.

ba28fae introduced a new bug where a few shaders show a heavy magenta cast. This only applies in tate mode.

Expected behavior

No response

Steps to reproduce the bug
  1. load any game that defaults to TATE mode. 90/270 rotation
  2. or force any game into rotation under settings->video
Version/Commit

4503b1d

Bisect Results

2d37811

Present in the nightly version

Yes, this is reproduced in the nightly build

Platform & operating system

macOS 27, Metal driver

Affected Cores

No response

Environment information

macOS 27
Metal Driver

Relevant log output

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing commits 2d37811 and ba28fae, then reproduce 90/270-degree TATE rotation on macOS with the Metal driver using the listed game or forced video rotation settings. Check orientation and shader output across Tahoe and Sonoma; done means rotation changes correctly without the reported magenta cast in affected shaders.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, macos
Domain
computer-graphics, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.