Double Binding Regression
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
Is there an existing issue for this?
- This is a bug in RetroArch frontend
- I have searched the existing issues
Description
Since updating to version 1.22.2 my hotkey configuration of select as well as having select bound to fast forward (hold) causes the menu toggle to no longer work, the remaining hotkeys work fine.
Removing the fast forward (hold) bind from select allows the menu hotkey to work.
In this instance it is with my gamesir controller which is similar to an xbox360 controller.
Expected behavior
In 1.21.0 this setup worked without issue, when the select key is held and the menu toggle is pressed, the menu opens.
Steps to reproduce the bug
- Bind the select button to the retroarch hotkey enable
- Bind the select button to fast forward (hold)
- Bind the menu toggle
- Try to open/close the menu with select + the menu toggle
Version/Commit
1.22.2 Stable
Bisect Results
No response
Present in the nightly version
Yes, this is reproduced in the nightly build
Platform & operating system
Windows
Affected Cores
No response
Environment information
No response
Relevant log output
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the shared Select binding on Windows with RetroArch 1.22.2 or the nightly, then compare it with 1.21.0. Trace the hotkey-enable, fast-forward-hold, and menu-toggle handling described in the steps; done means the menu opens and closes when Select and the menu toggle are used together, without breaking the remaining hotkeys.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100