Deleting a Favorite when two games with same title - doesn't delete correct game
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
Is there an existing issue for this?
- This is a bug in RetroArch frontend
- I have searched the existing issues
Description
Added two games with the same title to Favorites. One is the 32X version and the other is SNES. Removing one of them doesn't necessarily remove the selected one from Favorites.
- Import and Scan the SNES and 32X version of Star Trek - Starfleet Academy - Starship Bridge Simulator (USA)
- Add both to Favorites
- Remove the SNES version from Favorites
- Notice that it incorrectly removes the 32X version from Favorites. The SNES version remains in Favorites
Repeated test multiple times.
RetroArch 1.22.2
Expected behavior
It should Remove the selected game
Steps to reproduce the bug
- Import and Scan the SNES and 32X version of Star Trek - Starfleet Academy - Starship Bridge Simulator (USA)
- Add both to Favorites
- Remove the SNES version from Favorites
- Notice that it incorrectly removes the 32X version from Favorites. The SNES version remains in Favorites
Version/Commit
1.22.2
Bisect Results
No response
Present in the nightly version
I don't know
Platform & operating system
Windows 10
Affected Cores
No response
Environment information
No response
Relevant log output
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in RetroArch's Favorites view using two games with the same title but different platforms. Start by locating the Favorites removal entry point and trace how the selected game is identified; done means removing the selected SNES entry without removing the 32X entry.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100