libretro / libretro/RetroArch

HDR Android widget corruption/Windows,Linux high nit widgets

Open
#18,677 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Is there an existing issue for this?
  • This is a bug in RetroArch frontend
  • I have searched the existing issues
Description

Im reporting a bug that I effectively introduced in HDR for performance and quality reasons with the hope that someone can either point me in the right direction or implement a feature in the widget system. To fix both of the bugs we need a way to tell if a widget is visible on screen - not that we have any widgets currently active.

We have flags for this for the overlay and menu systems but not the widget system. In the Vulkan driver the menu and overlay visible flags can be tested like so: vk->flags & VK_MENU_VISIBLE (or something along those lines for the name #define).

If anybody knows how to test for this in the gfx drivers already Im all ears as my first attempts just got flags that are always active and this causes performance issues on lower end devices such as Android (where the issue causes corruption on screen whilst the widget is up)

Expected behavior

No corruption on Android, same nits as rest of menu system on Windows/Linux

Steps to reproduce the bug

Enable HDR, trigger a widget to be displayed on screen

Version/Commit

Nightly

Bisect Results

No response

Present in the nightly version

I don't know

Platform & operating system

Any system that supports HDR

Affected Cores

No response

Environment information

No response

Relevant log output

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by tracing HDR widget visibility through the widget system and Vulkan driver, comparing the existing menu and overlay visibility flags. Reproduce with HDR and a displayed widget on Android, Windows, and Linux; done means no Android corruption and matching widget nits across the affected platforms.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, c
Domain
frontend, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.