[Feature Request] First time download of a core should download system files and core.info file too
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
I noticed while testing the manual scanner if you don't have a core info file and have file browser set to filter "unknown file types" (the default), and scan without setting a extension to check, the scan fails
The extensions option says and I quote "List of file types to include in the scan, separated by spaces. If empty includes all file types or if a core is specified, all files supported by the core."
If empty and a core is specified ( normal situation when the user selects the core but not extensions), and you don't have the info file, naturally, it finds no file extensions and fails the scan
I find this setting a bit confusing and I'm not sure of its interactions with the file browser setting (ideally they would be "none" and those settings would only be for the user navigation of directories)
But regardless of that a first time download of a core needs the core info file for the user not to think the manual scanner is broken.
And if you're doing that, I think you might as well download the required data files for that core if any (ex: dolphin.zip) since games need them and the user doesn't necessarily know.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the manual scanner's first-time core download path and trace how the core.info file and required data files such as dolphin.zip are handled. Review the interaction with the empty extensions option and the file browser's unknown-file-types filter. Done means a first-time core download provides the files needed for scanning and core-supported games without requiring manual setup.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100