libretro / libretro/RetroArch

mismatch between documentation and behavior for vfs's seek function

Open
#18,582 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

With https://github.com/libretro/RetroArch/commit/85ae584b09d239e8ef05476ec9550a50720f984c, cores using file_stream_transforms's fseek + filestream_vfs_init are broken.

This does affect FBNeo on all platforms (i had to disable vfs through https://github.com/libretro/FBNeo/commit/6f05f3900745190d9861305637580d615035a3b4 as a hotfix for now)

Tagging @white-axe

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the documentation for the VFS seek function with the behavior of file_stream_transforms using fseek and filestream_vfs_init. Reproduce the failure with the FBNeo scenario described in the issue and trace the relevant VFS entry points. Done means the documented behavior and actual seek behavior agree without breaking affected cores.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.