[Emscripten] CORS violation between buildbot.libretro.com and web.libretro.com
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
Is there an existing issue for this?
- This is a bug in RetroArch frontend
- I have searched the existing issues
Description
Thanks to the efforts of @JoeOsborn in commit 56014a27d6422bcac5c093531cb61cbad4ab7bea the emscripten build now has basic networking support. While this should (in theory) allow the user to access the online updater functionality, these network requests via XMLHttpRequest are being blocked by CORS between the two libretro.com subdomains.
Expected behavior
- Navigate to https://web.libretro.com/
- Press "Run" button to load RetroArch
- Select "Online Updater"
- Select "Update Cheats"
- No error / cheats.zip is downloaded successfully from the buildbot subdomain.
Steps to reproduce the bug
- Navigate to https://web.libretro.com/
- Press "Run" button to load RetroArch
- Select "Online Updater"
- Select "Update Cheats"
- Error in browser console showing that the request was blocked due to CORS
Version/Commit
1.21.0
Bisect Results
No response
Present in the nightly version
I don't know
Platform & operating system
Emscripten
Affected Cores
No response
Environment information
No response
Relevant log output
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the request from web.libretro.com and inspect the browser console and response from buildbot.libretro.com. The issue mentions no repository file or test, so first determine whether the required CORS change belongs in RetroArch or on the libretro.com hosting configuration. Done means selecting Online Updater > Update Cheats downloads cheats.zip without a CORS error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, wasm
- Domain
- networking, web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100