libretro / libretro/RetroArch

The Simple Presets toggle for Shaders doesn't apply until restarting Retroarch

Open
#17,498 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Is there an existing issue for this?
  • This is a bug in RetroArch frontend
  • I have searched the existing issues
Description

Retroarch won't save "simple preset" .slangp files with links to the original shader + changes if you turn the "simple presets" toggle off then on again, until Retroarch is restarted.

Expected behavior

No response

Steps to reproduce the bug
  1. While Retroarch is running, you can save a simple preset for a core/game and see the simple link .slangp file update in windows explorer/notepad.
  2. You can toggle it off, save the file again, and see the .slangp file update to no longer be a simple link.
  3. However, if you turn it ON again and save it, it will not be a simple link. It will not save simple preset files until you restart retroarch.
Version/Commit

1.20.0

Bisect Results

No response

Present in the nightly version

I don't know

Platform & operating system

Windows 10

Affected Cores

No response

Environment information

No response

Relevant log output

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in RetroArch 1.20.0 on Windows 10, focusing on the Simple Presets toggle and shader preset save flow. Trace the code reached when the toggle is changed and a .slangp preset is saved; done means turning the option on again takes effect without restarting and writes a simple-link preset.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.