libretro / libretro/RetroArch

Thumbnails are not saved on state save after the first time.

Open
#16,759 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

First and foremost consider this:

  • Only RetroArch bugs should be filed here. Not core bugs or game bugs
  • This is not a forum or a help section, this is strictly developer oriented

Description

Thumbnails are not saved on state save after the first time.

Expected behavior

Thumbnails are saved.

Actual behavior

The following message is printed and the thumbnail is not saved.
Failed to take screenshot.

Steps to reproduce the bug
  1. Enable state-saving thumbnails.
  2. State save is performed. x2
  3. The state save itself succeeds, but fails to save the thumbnail.
Bisect Results

This problem has probably existed since state save thumbnails were first implemented.

Version/Commit

You can find this information under Information/System Information

  • RetroArch: [1.19.1/8aa5fd2]
Environment information
  • OS: Windows11

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named. Reproduce the issue on Windows 11 with RetroArch 1.19.1/8aa5fd2 by enabling state-saving thumbnails and saving state twice; done means the second save preserves its thumbnail without printing “Failed to take screenshot.”

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.