libretro / libretro/RetroArch

Update used SDL2 version for the Windows build

Open
#16,717 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Description

It seems like RetroArch for Windows is built with a rather old SDL2 version, this version has an annoying "feature" where it turns on the Switch Pro Controller LED. It would be nice if it is updated so it will stop doing that.

Expected behavior

For RetroArch to ship with a new enough SDL2 that doesn't turn on the switch pro controller home led.

Actual behavior

It doesn't. The home LED gets turned on when RetroArch is set to use the SDL2 controller driver.

Steps to reproduce the bug
  1. Open RetroArch with the SDL2 controller driver and connect a switch pro controller.
Bisect Results

[Try to bisect and tell us when this started happening]

Version/Commit

You can find this information under Information/System Information

  • RetroArch: 1.19.1
Environment information
  • OS: Windows 11 x64
  • Compiler: [In case you are running local builds]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a file or test. Start by locating the Windows build configuration and its SDL2 dependency, then check the SDL2 controller-driver path with a Switch Pro Controller on Windows. Done means RetroArch ships with a sufficiently new SDL2 version and the controller home LED no longer turns on.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.