[iOS] Retroarch app does not go 'fullscreen' app/does not hide the home bar while ingame
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
Not really sure if this is a feature request or bug report but the RetroArch app doesn't override any of the edge swipe gestures so any swipe from the top or bottom of the screen will either close the app, open notification centre, or open control centre depending on where you swipe from. The Home bar on notched devices will also constantly fade in or out at the bottom of the screen which can be mildly distracting and be on top of content.
I'm mainly having an issue with this on DS games, because if you use some sort of display setting (for example hybrid with the bottom display the main display) that makes the DS' lower touchscreen extend to the device edges makes some titles very difficult to play, for example Plants vs Zombies, as swiping down from the top edge (required to place your plants) opens the notification centre.
There is a property in UIViewController that allows the app to override the stock iOS swipe commands and require a double swipe to access the NC/CC/home screen, which I think should be enabled whenever RA is actively playing a game, both to help with DS titles and to remove the Home bar from overlapping the game whenever the device is in landscape.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to UIViewController.preferredScreenEdgesDeferringSystemGestures; start by locating the iOS game view controller and checking how it is presented while a game is active. Done means edge swipes require the requested extra gesture and the Home bar no longer overlaps landscape gameplay, including DS touchscreen layouts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100