libretro / libretro/RetroArch

Default input_block_timeout = 0 (settings>latency>input block timeout) may accumulate input from gamepad in some Android TV

Open
#16,409 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

In Haier with Android TV noticed some weird bug.
If you press quickly buttons at short time it's bufferize input from gamepad. When you stop pressing buttons the game still recognizes button presses like it accumulated a press button queue
Someone found that it's not happened with old version of retroarch, but not exactly remembered a version. I tried to downgrade as many times as needed from 1.17.0 without saving configuration file.
I found that input work correctly in 1.10.3, but not in 1.11.0. What I found interesting in the changlelog for 1.11.0
"INPUT: Fix off by one error for input_block_timeout setting. Also default to 0 for this setting (pretty massive performance gain)"
Version 1.10.3 defaults input_block_timeout = 1, but 1.11.0 defaults input_block_timeout = 0
When I set input_block_timeout = 1 (settings>latency>input block timeout), that fixes a problem in new version of retroarch in Haier with Android TV. Input works without accumulating button press queue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the input_block_timeout behavior and defaults between RetroArch 1.10.3 and 1.11.0, focusing on the Android TV gamepad path described here. Reproduce rapid button presses on the Haier device with the setting at 0 and 1; done means the default behavior no longer accumulates queued presses.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, c
Domain
frontend, mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.