libretro / libretro/RetroArch

"Save Controller Profile": duplicated variables, and incorrectly sorted variables

Open
#16,254 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Description

Settings -> Input -> RetroPad Binds -> Port 1 Controls -> Save Controller Profile.

These errors occur intermittently, and I have never been able to replicate them right after observing them. For instance, when I delete the autoconfig file and click Save Controller Profile again, the new autoconfig file is generated correctly.

To date, I've observed these bugs while creating autoconfig files using the following controller drivers:

  • android
  • linuxraw

Extra input_up_btn

  • RetroArch 1.19.1 Appimage:
  • Controller: Nintendo Switch Pro Controller
  • OS: Ubuntu MATE 23.04 live mode
input_driver = "linuxraw"
input_device = "Nintendo Switch Pro Controller"
input_up_btn = "0"
input_b_btn = "0"
input_y_btn = "3"
input_select_btn = "9"
input_start_btn = "10"
input_up_axis = "-5"
input_down_axis = "+5"
input_left_axis = "-4"
input_right_axis = "+4"
input_a_btn = "1"
input_x_btn = "2"
input_l_btn = "5"
input_r_btn = "6"
input_l2_btn = "7"
input_r2_btn = "8"
input_l3_btn = "12"
input_r3_btn = "13"
input_l_x_plus_axis = "+0"
input_l_x_minus_axis = "-0"
input_l_y_plus_axis = "+1"
input_l_y_minus_axis = "-1"
input_r_x_plus_axis = "+2"
input_r_x_minus_axis = "-2"
input_r_y_plus_axis = "+3"
input_r_y_minus_axis = "-3"

Less detailed loggs

Example 1: incorrectly sorted input_up_btn, duplicated input_a_ variable (input_a_btn)

  • RetroArch unknown version (Flatpak or Appimage released September 2024)
  • Controller: Sony DualSense
  • OS: Unknown (Ubuntu 20.04 or later based distro)
input_driver = "android"
input_device = "DualSense Wireless Controller"
input_vendor_id = "1356"
input_product_id = "3302"
input_b_btn = "97"
input_y_btn = "96"
input_select_btn = "104"
input_start_btn = "105"
input_down_btn = "h0down"
input_left_btn = "h0left"
input_right_btn = "h0right"
input_a_axis = "-1"
input_x_btn = "100"
input_l_btn = "99"
input_r_btn = "0"
input_l2_axis = "+2"
input_r2_axis = "-3"
input_l3_btn = "109"
input_r3_btn = "108"
input_l_x_plus_axis = "+0"
input_l_x_minus_axis = "-0"
input_l_y_plus_axis = "-3"
input_l_y_minus_axis = "+3"
input_r_x_plus_axis = "+0"
input_r_x_minus_axis = "-1"
input_r_y_plus_axis = "+1"
input_r_y_minus_axis = "-1"
input_up_btn = "h0up"
input_a_btn = "0"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the “Save Controller Profile” action and the autoconfig generation code used by the android and linuxraw input drivers. Reproduce the intermittent output with the examples in this issue, then verify that generated profiles contain no duplicate variables and are consistently sorted.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.