libretro / libretro/RetroArch

Compiling with emscripten version 3.1.52 does not work

Open
#16,160 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

(see https://github.com/emscripten-core/emscripten/issues/21128)

As said in the title, Compiling with emscripten version 3.1.52 does not work because the emscripten compiler actually checks to see if input files are what they are now (https://github.com/emscripten-core/emscripten/pull/20922) (It appears the initial emscripten port was incorrect in that field)

Before I went and did anything I wanted input on what should be done. There are 2 options from my point of view

  1. State compiling with emscripten 3.1.52 and up is not supported. Though note this will quickly make the emscripten builds outdated and isnt optimal for the long term
  2. Enable static linking for all cores, and properly name the files .a as emscripten expects, as well as change the targets in the makefile and dist-cores script

In my project (EmulatorJS) I have chosen the second option, since I try to stay with up to date emscripten, but wanted input before I went and submited about 20 prs.

Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked Emscripten issue and the repository's Makefile and dist-cores script, which the report identifies as affected entry points. Compare the current core targets and archive names with Emscripten 3.1.52's expectations. Done means a decided approach is implemented consistently and cores compile with that Emscripten version.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system, compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.