libretro / libretro/RetroArch

PC98 Core - np2kai can't save state in android

Open
#16,044 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

First and foremost consider this:

  • Only RetroArch bugs should be filed here. Not core bugs or game bugs
  • This is not a forum or a help section, this is strictly developer oriented

Description

[Description of the bug]
Save state does not work on np2kai core in current RetroArch android app.
I have tested with the latest np2kai (0.86 rev 91) and works well.
So please update below source.
https://github.com/libretro/NP2kai

Expected behavior

[What you expected to happen]
Save state works well

Actual behavior

[What is actually happening]
Android Application crashed

Steps to reproduce the bug
  1. Run PC98 game with np2kai core
  2. Save state
Bisect Results

[Try to bisect and tell us when this started happening]

Version/Commit

You can find this information under Information/System Information

  • RetroArch: 1.16.0 (The latest version on Galaxy Store at current date)
Environment information
  • OS: Android
  • Compiler: N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the crash in an Android RetroArch build using the np2kai core, following the two steps in the report. Read the linked NP2kai repository and compare its save-state behavior with the version used by RetroArch 1.16.0; done means saving a state no longer crashes the Android application.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, c
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.