Core path overwritten when launching via CLI with a non-core path in -L
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
Description
When launching via CLI, the -L flag is used to designate a core name or the path to a core. If you mistakenly use a directory here, it will overwrite the stored directory for cores.
Expected behavior
Providing invalid input via -L should discard the input, either not starting retroarch or just loading to the main menu.
Actual behavior
Invalid input is stored as the new path for cores.
Steps to reproduce the bug
- Run
retroarch -L some/path - Check the cores path in Settings > Directory
Bisect Results
<Bisect not done, but can be if necessary>
Version/Commit
- RetroArch: 1.16.0 (Git e71a83e5c4) Nov 12 2023
Environment information
- OS: Garuda Linux current x86_64 (Arch variant)
- Compiler: GCC (13.2.1) 64-bit
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing retroarch -L some/path on RetroArch 1.16.0 and inspect how the CLI -L value is handled before the cores path is stored. Compare the resulting value in Settings > Directory with valid core-name or core-path input. Done means an invalid directory is discarded and RetroArch either does not start or opens the main menu without overwriting the stored cores path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100