libretro / libretro/RetroArch

Cannot undo load state on the auto-loaded state (only in SameBoy core)

Open
#15,414 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

First and foremost consider this:

  • Only RetroArch bugs should be filed here. Not core bugs or game bugs
  • This is not a forum or a help section, this is strictly developer oriented

Description

I originally reported this in the SameBoy repo here: https://github.com/LIJI32/SameBoy/issues/553
SameBoy's developer thinks this is more likely to be a RetroArch related issue, despite only affecting the one core (see that issue for their explanation). At their request, I'm opening the issue here for further investigation into this possibility. The below is copied and pasted from the original issue:

Bit of a weird issue, and I'm not positive that this is a core issue and not a RetroArch issue, but so far SameBoy is the only affected core I've found.

When using the option to automatically load the last state when opening content, attempting to undo that load results in an error message stating that no state was loaded to undo. This only happens with the initial auto load. Manually loading a state and undoing it works fine. And as stated before, among the 20 or so cores I use, I've only discovered this issue in SameBoy.

This was tested on multiple Android devices. Unfortunately, I have no access to a PC for the time being.

Expected behavior

A state is automatically loaded when content is launched. Selecting "undo load state" after this reverts the content back to its freshly launched state, as is the behavior on every other core (that I've tested).

Actual behavior

Selecting "undo load state" after a state is automatically loaded results in a notification that no state was loaded.

Please note that simply using the "restart" option is not a suitable workaround, as the save data associated with whichever state was loaded remains loaded at this point (and has overwritten whatever data existed before).

Steps to reproduce the bug
  1. Enable auto state loading.
  2. Launch content with SameBoy and save a state.
  3. Close content.
  4. Load the content with SameBoy again.
  5. After the state is automatically loaded, select the "Undo load state" option.
Bisect Results

Haven't tested for this extensively, but the issue has occurred for as long as I've been testing out SameBoy (about the past few weeks).

Version/Commit

You can find this information under Information/System Information

  • RetroArch: 1.15.0
Environment information
  • OS: Android 13/One UI 5.1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Begin with RetroArch's auto state loading and "Undo load state" paths, comparing the initial automatic load with a manual load. Reproduce the five listed steps with SameBoy if possible on Android 13/One UI 5.1; done means undoing the automatically loaded state restores freshly launched content without the "no state was loaded" notification.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, c
Domain
frontend, mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.