Renaming a favorite shouldn't delete its name
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
Description
When you rename a ROM in the Favorites list the rename pop up is empty. Even if you just want to add a few letters or a digit you have to manually type the entire ROM name.
It's especially time consuming if you've made a typo when you renamed the favorite game and corrected it. Then you have manually typed the entire ROM name twice :)
Expected behavior
Text input pop-up should have the current ROM / favorite name when you rename it.
Actual behavior
The text input pop-up is always empty / discarded when it appears.
Steps to reproduce the bug
- Add a ROM as favorite
- Go to Favorites and rename the entry
- Note that the renaming pop-up is empty
Bisect Results
Has been present for years.
Version/Commit
- RetroArch: 1.15.0, 1.14 and probably earlier.
Environment information
- OS: Confirmed on Android, AmberElec and PSVita.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the rename flow from Favorites on one of the reported platforms, such as Android, AmberElec, or PSVita, and trace where the rename pop-up is opened. Verify that the current favorite name is present when editing and that correcting or extending it preserves the existing name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100