Changing shaders on Mac OS using Metal does not immediately apply in fullscreen mode
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
Description
Changing shaders (on the Snes9x-current core) using RetroArch_Metal on Mac OS 12.6.2 Monterey using the Metal driver does not immediately apply in fullscreen mode. For example, when using the scalefx-aa-fast preset, and then turning of shaders completely via Quick Menu => Shaders => Video Shaders = off, the previous shader stays in effect when resuming the emulation. It is necessary to exit fullscreen to make the shader changes take effect.
I already used a nightly build where the previous Metal bug with the slow down bug was fixed. My build is from January 7th.
Expected behavior
Shaders changes should take effect immediately when Apply changes is activated or when they are turned off completely.
Actual behavior
Shader changes only take effect when switching from fullscreen to windowed mode.
Version/Commit
- RetroArch: Metal Nightly Mac OS build from January 7th 2023
Environment information
- OS: Mac OS 12.6.2 Monterey
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with RetroArch_Metal on macOS 12.6.2 in fullscreen mode, using the scalefx-aa-fast preset and the Quick Menu shader controls. Trace the Metal fullscreen shader-application path and verify that changing or disabling shaders takes effect without switching to windowed mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- computer-graphics, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100