libretro / libretro/RetroArch

Gambatte palettes notifications are not synchronised with the currently selected palette (Linux / SDL1.2 / RGUI)

Open
#14,673 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Description

(This is a copy of this issue made on the Gambatte repo, I think that it finally more about the frontend).

Since this pull request : https://github.com/libretro/gambatte-libretro/pull/204 , it is possible to switch between gambatte palettes via RetroPad L/R that's very nice and works well but when using RGUI on Miyoo Mini (a little linux handheld) each notification doesn't not override the previous one.
So if you change quickly 5 palettes you'll see previous palettes names on notifications and you don't know which is the current one. This little problem is very annoying to choose your palette.

One Retroarch for Windows the notifications toasters are not the same and each new palette notification override the previous one in the right way.

A little video to illustrate (I press 3 times R and 2 times L)

https://user-images.githubusercontent.com/7110113/197071605-f1a19c87-a408-4792-854c-13cdb20f2c84.mp4

As you can see the notifications are late.

(I have hesitated to create this issue in Retroarch repo as the callback to enable cores to notify is in Retroarch I'm not very sure.)

Expected behavior

As on retroarch for Windows the new notifications for gambatte palettes should override the previous one.

Actual behavior

On RGUI, each notification is displayed for a determined time so the current selected palette is not synchronised with the current notification.

Steps to reproduce the bug
  1. Use RGUI with old notification style (linux notification style ? Or is it related to SDL 1.2 ?)
  2. run gamebatte core
  3. press L and R multiple time to observe the lack of synchronisation
Version/Commit

You can find this information under Information/System Information

  • RetroArch: [version/commit]
    10.0.0
Environment information
  • OS: Linux on Miyoo Mini
  • Compiler: GCC, SDL 1.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start with the RetroArch callback referenced in pull request #13079 and trace how RGUI's old notification style handles rapid palette changes on Linux/SDL 1.2; done means a new Gambatte palette notification replaces the previous one when L/R is pressed repeatedly.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, linux
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.