libretro / libretro/RetroArch

Possible bug in function for deleting save-states?

Open
#14,583 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Description

After deleting older save-states, I was unable to load my remaining save-state.

Expected behavior

I should be able to load any remaining save-states, regardless of what was deleted previously.

[What you expected to happen]
I expected to delete save-states 0-18 and leave 19 remaining and playable.

Actual behavior

After deleting save-states 0-18, with 19 remaining, I tried to load save-state 19. Instead, text on-screen indicated: "loading from auto-save SRM" or something like that. Then, I exited the game and re-started. Save-state 19 was gone.

Steps to reproduce the bug
  1. Play Pokemon Blue, make many save-states. Also save using the normal Gameboy cartridge save function.
  2. Delete older save states, leave the most recent one remaining.
  3. Try to launch the most recent save-state.
  4. Observe: latest save-state is not launch, instead a much older SRM file is loaded.

Disclaimer, I have not attempted to reproduce this yet. Just describing the sequence of events as I saw it. It's possible this is some kind of user-error but I am quite certain of the sequence of events here.

Bisect Results

Haven't attempted.

Version/Commit

Build: Nov 30 2021
Git RG351MP.aarch64-prerelease-20211130_1728
RetroArch: 1.9.13

I understand my build is somewhat outdated but I didn't see this as a closed or open issue, so I decided to log this issue.

Environment information

Frontend OS: Linux 4.4
GCC 10.3.0 64-bit

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The report does not name a source file, test, or entry point. First reproduce the save-state deletion and loading sequence with Pokemon Blue and the stated RetroArch build, then trace the save-state and SRM loading behavior; done means the remaining save-state loads successfully after earlier states are deleted.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.