Option "Sync to Exact Content Framerate (G-Sync, FreeSync)" is mislabeled
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
First and foremost consider this:
- Only RetroArch bugs should be filed here. Not core bugs or game bugs
- This is not a forum or a help section, this is strictly developer oriented
Description
Consider devices with no audio interface, or a blocked or not correctly initialized audio interface (e.g. Pi4 with HDMI output plugged into port 2 instead of port 1 which results in no audio). On such devices, all cores will automatically speed up to max fps. With Vsync, this is fps of display, without vsync, this is 100fps or more.
The only way to have cores run in correct speed without audio is to set "Sync to Exact Content Framerate (G-Sync, FreeSync)" to ON. This allows the core to be throttled to correct speed, even when there's no audio interface or a blocked audio interface.
Expected behavior
It behaves correct, but the option is mislabeled. I don't have G-Sync or FreeSync, but still the option helped prevent the cores from running too fast, for example Amiga PAL 50 Hz was prevented to run at 60 fps.
Actual behavior
It behaves correct, but the option should be labeled "Sync to Exact Content Framerate" with NO reference to G-Sync or FreeSync, because G-Sync or FreeSync is irrelevant.
Steps to reproduce the bug
- Launch Commodore Amiga PUAE core on a device with no audio, e.g. Pi4 with HDMI plugged into port 2 not port 1 (no audio plays in that case).
- Open Status bar by pressing select to bring up vkbd and selecting statusbar on vkbd.
- Observe the incorrect 60 fps counter on bottom right (should be 50).
- Enable video->synchronization->Sync To Exact.... option.
- Observe fps in core is now correct at 50 Hz, even without G-Sync/FreeSync.
Version/Commit
Latest 1.10.2
Environment information
- OS: Pi 400, Lakka.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the frontend/UI source for the option label "Sync to Exact Content Framerate (G-Sync, FreeSync)". Verify the wording in the video synchronization menu and reproduce the reported PAL 50 Hz scenario on the stated Lakka/Pi setup; done means the label no longer references G-Sync or FreeSync while the existing behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100