[WIIU] Overlays are always full_screen
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
Description
Some overlays are intended to only fill the game area, like several of those in https://github.com/libretro/common-overlays/tree/master/effects/scanlines
These overlays behave the same as overlays with overlay0_full_screen = true, filling the entire screen with scanlines rather than just the game image.
Expected behavior
The default setting for overlay0_full_screen is false, so any overlay that either doesn't include this setting or sets it to false should only fill the game area.
Actual behavior
They fill the entire screen.
Steps to reproduce the bug
- Set a directory for
overlaysin the directory settings (Wii U has no default overlay directory). - Download the overlays.
- Enable any overlay that is intended to display only over the game image.
- Observe that the overlay fills the entire screen.
Bisect Results
I didn't bisect, I don't think anybody really uses overlays on Wii U so it's pretty likely it's just always been this way and nobody noticed.
Version/Commit
- RetroArch: 4ffe9dc
Environment information
- OS: Wii U, 5.5.5 PAL
- Compiler: Official libretro-build-wiiu Docker container
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing Wii U overlay rendering and the handling of the overlay0_full_screen setting, comparing overlays that omit it or set it to false with those that set it to true. Reproduce the issue with a scanlines overlay on Wii U, then verify that only the game area is covered.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- computer-graphics, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100