Calling your attention to ppsspp core problems

First and foremost consider this:

• Only RetroArch bugs should be filed here. Not core bugs or game bugs
• This is not a forum or a help section, this is strictly developer oriented

Description

I posted this here because libretro/ppsspp doesn't have a bug report tab.

Yes, i know the ppsspp core is upstreamed, this doesn't mean that upstream is going to fix bugs that only occur in the libretro port. Namely this one 'fix', which is basically a hack:

https://github.com/hrydgard/ppsspp/pull/14680

My problem with this is that this hack original problem comes from the libretro port not using the same config files (fair enough) and not replacing it by anything in the libretro core startup (not good). Hardcoding seems ok if you're never going to use RA libretro to play multiplayer ppsspp, but you'd think this would be a core option.

And while you're at it, check if any other piece of initialization data that exists in ppsspp was 'skipped' in the creation of this core. This comment by unknownbrackets is alarming https://github.com/hrydgard/ppsspp/issues/13115#issuecomment-891499805

' However, because libretro (for some reason?) bypasses all our configuration initialization code, this doesn't happen there. There's probably other things not initializing the Config class is doing wrong too.'

Expected behavior

ppsspp upstream initialization function(s) are either duplicated correctly for the libretro core framework so no more problems like this happen or the original code used somehow.

Actual behavior

There was a stealthbug that only existed in libretro, it was 'fixed' by hardcoding something which should be random and might have to be reverted or reworked to have multiplayer lan in the future of the core, and a upstream author is making noises about 'probably other things are broken'.

Function replacement hacks? Other networking subtleties? Who knows.

Start by reading the linked PPSSPP pull request and the upstream comment about skipped configuration initialization. Trace the libretro core startup path and compare it with PPSSPP's upstream initialization functions. Done means identifying the missing initialization areas and agreeing on a concrete implementation scope for the libretro port.