libretro / libretro/RetroArch

[msvc2005/2010] -20px height every time the window is "reinitialized" with the "Remember size and position" setting

Open
#12,468 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

platform: windows platform: windows (msvc2005) platform: windows (msvc2010)
Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Description

While trying to reproduce an issue with mvsc2005 and 2010 (https://github.com/libretro/snes9x2010/issues/146), I've noticed a very weird thing, if you're using RetroArch in windowed mode with the "Remember size and position" setting, the height will be down by 20px each time the window is "reinitialized", so each time you (re)start RA, each time you start/close content, etc.

https://user-images.githubusercontent.com/33353403/120166236-ab9c5200-c1fc-11eb-8371-d0b4f1894675.mp4

It looks like it goes down to "-20", then it stops doing it, of course with a -20 window height, well... you can't see anything excepted the RA title bar 😅

The issue does not exist in the non-msvc versions, and I haven't tried the msvc2017 version.

Expected behavior

If I set 1280x720 for example, it should stay at 1280x720.

Actual behavior

If I set 1280x720, next time I'll boot RA or boot a game it'll drop to 1280x700, then 1280x680, etc.

Steps to reproduce the bug
  1. Start RA, go to Settings > Video > Windowed and turn ON the "Remember Size and Position" setting (remember the window height).
  2. Restart RA, go back to the "Windowed" menu, you should see the height shorter by 20px.
  3. Restart again, another 20px, etc.
Bisect Results

No clue exactly, first time I'm testing the msvc builds (I'm on Windows 10) :p It was working in 1.9.0 and the issue was already here in 1.9.1, but because of the gap between the 2 versions I doubt this is a super helpful information...

Version/Commit
  • RetroArch: msvc2005 and 2010 stable versions
Environment information
  • OS: Windows 10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the window-size persistence problem on Windows 10 with the MSVC 2005 and 2010 builds, comparing behavior across RetroArch 1.9.0 and 1.9.1. The payload names no source file or test, so trace the code used when windowed size and position are restored or the window is reinitialized. Done means a remembered 1280x720 window remains 1280x720 after restarting and starting or closing content.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.