Make full-screen over notch configurable per orientation
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
This is a feature request.
On Android devices, the enable full-screen over notch setting applies in both portrait and landscape orientations.
I would like to be able to have it apply only in landscape. The reason being, in portrait orientation there is plenty of space between the game image and touch controls below. So I don't want/need any part of the top of the game image to be missing.
However in landscape mode having full-screen over notch enabled allows the touch controls to be slightly wider, overlapping slightly less of the game image. (None of the 4:3 game image is cut off with either setting in landscape of course, since the phone screen is far wider than 4:3.)
Just to complicate things... When the glui menus are shown, I want the opposite to happen. In portrait having the middle of the status bar obscured by notch cutout is OK and it leaves more screen space for menu items. But in landscape mode the notch cutout covers part of the middle menu item text.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Android full-screen-over-notch setting and the orientation-specific GLUI menu handling. Trace how portrait and landscape currently share the setting, then determine the separate behavior required for gameplay and menus. Done means the notch setting can be configured independently by orientation without obscuring the intended menu text.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, c
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100