libretro / libretro/RetroArch

Blargg_NTSC_SNES CPU Filter bug with any SNES core

Open
#12,231 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

video filter
Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Description

It appears to be a problem with the aspect ratio and whenever the filter goes into one of the snes' hi-res modes, there's more about it here https://forums.libretro.com/t/possible-bug-with-blarggs-filters-in-the-snes9x-core/32746/6

Expected behavior

To display the video output proportionately an accurately

Actual behavior

Doom (J)-210404-183229

Steps to reproduce the bug

Not entirely sure

  1. Select your bsnes core with game as you normally would
  2. Apply your shader which is fine
  3. Apply the BLARGG NTSC RGB CPU filter under video settings
Bisect Results

Occasionally the aspect ratio goes too slim in some games like the image above, on DOOM it's the intermission screens and startup screens.

Version/Commit

git: cf6ca2a

  • RetroArch: v1.9.1 built March 28 2021
Environment information
  • OS: Windows 10 x64
  • Compiler: Mingw 10.2.0 64-bit

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the BLARGG NTSC RGB CPU filter under RetroArch's video settings and reproduce the issue with a bsnes or other SNES core, including a hi-res mode such as the one described for DOOM. Compare the output aspect ratio with and without the filter and consult the linked forum discussion. Done means SNES video output remains proportionate and accurate in affected screens.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.