libretro / libretro/RetroArch

You have to put a space after the name of the property key and before the equals sign

Open
#11,714 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

configs
Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

This works:
input_player1_joypad_index ="2"
This doesn't:
input_player1_joypad_index="2"

That's correct, the build released Feb 2, 2020 requires a space before the equals sign on all property files and overrides. If it wasn't difficult enough to get the proper joystick enabled in your core/platform/game with fixed arcade style controls and a virtual 3rd joystick, this definitely doesn't do any programmer or end user any favors...

Actual behavior

Apparently the key name should be:
input_player1_joypad_index
instead of:
input_player1_joypad_index
(hint the first variable name has a space behind it.)

Environment
  • RetroArch: version: 1.8.4 git hash:9e25601
  • OS: Rasbian
  • Compiler: GCC (8.3.0) 32-bit

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the parsing difference between input_player1_joypad_index ="2" and input_player1_joypad_index="2" using the reported RetroArch 1.8.4 environment. Trace how property files and overrides parse the key and verify that both forms are handled consistently without changing the intended value.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.