libretro / libretro/RetroArch

Cheat iteration does not work when setting Memory search bits maximum value

Open
#11,581 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cheats
Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

First and foremost consider this:

  • Only RetroArch bugs should be filed here. Not core bugs or game bugs
  • This is not a forum or a help section, this is strictly developer oriented

Description

When setting an iterative cheat sets the value of more than one memory address, the iteration will fail when setting the value to max. value.

Expected behavior

The iteration should work correctly and each memory address value should be set to it's max. value

Actual behavior

Only the selected memory address value is changed

Steps to reproduce the bug
  1. Go to Cheats menu
  2. Configure a new cheat as follows:
  • Handler: RetroArch
  • Memory search size: any (e.g. 8-bit)
  • Type: Set value
  • Value: max. value (e.g. 0xFF)
  • Memory address: any (e.g. 0x786C6)
  • Number of iterations: more than one (e.g. 5)
  • Address increase each iteration: 1
  1. Enable the cheat
  2. Apply changes
Bisect Results

Git version which enables Set value with max. value (0705650c18)

Version/Commit
  • RetroArch: 1.9.0 0705650c18
Environment information
  • OS: Windows 10 x64

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue from the Cheats menu using an 8-bit Set value cheat, a maximum value such as 0xFF, and multiple iterations. Compare behavior around commit 0705650c18 and verify that every iterated memory address receives the maximum value on Windows 10.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.