Fast Forward toggle option not working properly whilst button is still held upon toggling it off

Description

Fast Forward Toggle breaks control of a button which was still held after untoggling fast forward. Controllers only.

Expected behavior

Example - Dashing in a game by pressing its dash button (such as FFVII) and then fast forwarding with toggle option and toggling off fast forward should continue the dash smoothly, even when coming out of fast forward

Actual behavior

If you toggle fast forward ON with a controller while you’re dashing in a jrpg (like holding A to move faster) then toggle fast forward OFF while still holding dash button, it will no longer be continuous dash after you turn fast forward OFF. Instead it bugs out to every other step where the character walks then dashes intermittently. It’s fixed easily by letting go of the dash button and holding it down again but still this wasn’t a problem before with fast forwarding on previous versions.

Steps to reproduce the bug

1. Toggle fast forward ON while holding a button, such as dashing in FFVII with X or any other game that has dash. Dashing is just an example. There may be other ways to recreate it depending on game. Resident Evil is another example where you can run.
2. Toggle fast forward OFF while still having dash held. Notice how the dashing is now broken and happens intermittently rather than continuously as if it’s being pressed on and off very fast rather than held.
3. This can be fixed by letting go of the dash button and repressing. Only happens with a controller and Toggle option of fast forward. The Hold option for Fast Forward works fine and also the toggle option using keyboard works fine too. Issue seems to be with controllers only and happens with any button on the controller as I tried it on two different games and cores that both used different buttons to dash in a game. I am using Dual Shock 4.

Bisect Results

Started happening after I updated to latest stable build of Retroarch

Version/Commit

Aug 12 2020 C70c13c01d

Environment information

• OS: Windows 10 Build 18363 v10.0
• Compiler: MiniGW 9.2.0 64-bit

Start by reproducing the issue using the controller-only steps with a Dual Shock 4, fast-forward Toggle mode, and a held dash or run button. Compare controller input handling when fast forward is toggled off with keyboard input and Hold mode. Done means a held controller button remains continuous after toggling fast forward off, without requiring release and re-press.