Can't combinate different SLANG shaders with same name of parameter.
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
First and foremost consider this:
- Only RetroArch bugs should be filed here. Not core bugs or game bugs
- This is not a forum or a help section, this is strictly developer oriented
Description
Can't combinate different SLANG shaders with same name of parameter.
Expected behavior
Shader preset should create. And Retroarch should know which parameter goes to which shader.
Actual behavior
Failed to save such shader preset.
Steps to reproduce the bug
Described in https://github.com/libretro/slang-shaders/issues/142
Bisect Results
[Try to bisect and tell us when this started happening]
Version/Commit
You can find this information under Information/System Information
- RetroArch: 6df4e7778f
Environment information
- OS: [The operating system you're running]
- Compiler: [In case you are running local builds]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproduction described in libretro/slang-shaders issue 142, then trace RetroArch's shader-preset creation and save failure. Done means a preset combining different slang shaders with the same parameter name can be created and saved while associating each parameter with the correct shader.
Written by the indexing model from the issue text.
Assessment
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100