libretro / libretro/RetroArch

Menu widgets pop-up causing pillarboxing

Open
#10,541 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Description

The menu widgets pop-up for retroachievement leaderboards can cause a pillarboxing effect (reverse letterboxing) that will blackout the left and right sides of the screen flanking the notification text and obscuring all parts of the screen that are not directly above or below the notification. The effect will remain until the game is reset or another leaderboard pop-up occurs.

Prior to bug
MVIMG_20200430_012607

During bug
MVIMG_20200430_012625

Steps to reproduce the bug
  1. Enable menu widgets: settings>onscreen display>onscreen notifications>graphics widgets on
  2. Enable achievements, hardcore mode, leaderboards.
  3. Load a game with leaderboards. I recommend Pac-Man for Atari 2600 MD5 - 6e372f076fb9586aff416144f5cfe1cb as you can quickly trigger leaderboard pop-ups by pressing start once the game starts.
Bisect Results

This issue seems to have started with the implementation of menu widgets. I've personally experienced the behavior on 1.8.1+ and I've seen it happen across a variety of cores.

Version/Commit
  • RetroArch: 1.8.5
Environment information
  • OS: Retropie 4.6 (raspbian buster)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with menu widgets, achievements, hardcore mode, and leaderboards enabled, using the Pac-Man Atari 2600 example and the stated RetroArch version. Trace the menu-widget notification rendering introduced around 1.8.1; done means leaderboard pop-ups no longer pillarbox or black out the sides of the screen, including across cores.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
computer-graphics, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.