GLCore Shader Issue.

Open
#10,444 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
c

Research direction

Reproduce the issue with aspect_ratio_index 10, shaders_slang/handheld/console-border/gb-dmg-alt-4x.slangp, and video_driver glcore on Windows. Compare the bezel output with the same setup using vulkan or gl, then trace the GLCore shader path; done means the bordered shader no longer repeats under GLCore.

Written by the indexing model from the issue text.

Description

bug: glcore shaders shaders: slang

Description

  • The bezel included in a handheld bordered shader repeats itself when setting:

    • f.e. aspect_ratio_index = 10 (which is 9:16, so vertical),
    • f.e. shader to f.e. shaders_slang/handheld/console-border/gb-dmg-alt-4x.slangp &
    • video_driver to glcore.
  • Shader bezel repeating example:
    image

  • This issue also happens for f.e. a Game Boy Advance bordered handheld shader
    (didn't test others at time of writing).

Expected behavior
  • It does not seem to happen when setting video_driver to f.e. vulkan or gl.

    • Note: using glsl shader preset when setting to gl.
  • Shader bezel expected behavior example:
    image

Actual behavior
  • See 'Description'.
Steps to reproduce the bug
  • See 'Description'.
Version/Commit
  • v1.8.5
  • 532fd88e2f
  • Compiler: MinGW (9.2.0) 64-bit - Built: Mar 19 2020
Environment information
  • OS: Windows
Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from libretro/RetroArch

All issues in libretro/RetroArch

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.