libretro / libretro/RetroArch

[3DS gPsp] : preserve rom's full filename with extension for saves

Open
#10,438 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Hello retro coders,

I tested lastest gPsp retroarch version (1.8.5) on my new 3ds with cia version.
The result is astonishing ! Very good compatibility (but still some bugs on some roms)
But when I load a rom, the file created in "/retroarch/cores/savefiles" folder on the SDCard doesn't contain the filename with extension.
I explain :

  1. I have a rom named as :
    "007 - NightFire (USA, Europe) (En,Fr,De).gba"
  2. I create a zip containing this rom named as :
    "007 - NightFire (USA, Europe) (En,Fr,De).gba.zip"
  3. I load the zip with gPsp
  4. I save the state to slot 0 let's say.
  5. I exit retroarch and go to see content in retroarch folders.

The result :
a)"/retroarch/cores/savefiles" : contains "007 - NightFire (USA, Europe) (En,Fr,De).sav"
b)"/retroarch/cores/savestates" : contains "007 - NightFire (USA, Europe) (En,Fr,De).gba.state"

The result b) is perfect. But the result a) is not correct and not conform to any other retroarch core's saves (snes9x, gambette, nestopia, genesis_plus_gx, etc.). The correct result should be, like others cores : "007 - NightFire (USA, Europe) (En,Fr,De).gba.sav"

This "problem" seems to be insignifiant, but I have at least ten cores. So ten cores writes to "/retroarch/cores/savefiles" and I like when I can filter the save thanks to its name (for exemple, I know that all ".gba.sav" are saves from gPsp. All ".psx.srm" are from pcsx_rearmed saves, all ".smc.srm" are from snes9x core saves, all ".gbc.srm" are from gambette saves (gameboy color)

This naming correction should be well appreciated.

Thanks.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the save behavior with the gPsp core using a zipped ROM, then trace the code that creates files under /retroarch/cores/savefiles. Done means the save filename preserves the ROM's full .gba extension, matching the requested form while keeping savestate naming unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.