(Menu) When creating/altering shader presets, apply is not saving to the preset name
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 14.1k
- Forks
- 2.2k
- Avg merge
- 7h 35m
- Merged PRs (30d)
- 51
Description
Description
modify or create a shader preset, click apply and it saves as retroarch.(slang,glsl,cg) instead of the presets name
Expected behavior
when clicking apply, it should save the preset (which is already set to auto load) instead of retroarch, xxx
Actual behavior
saves to retroarch.xxxx no matter the preset loaded
Steps to reproduce the bug
- load preset
- make changes
- click apply
Bisect Results
N/A
Version/Commit
You can find this information under Information/System Information
- RetroArch: 1.8.4
Environment information
- OS: win 10 64b 1909
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the menu shader-preset apply flow and reproduce the issue on RetroArch 1.8.4 with a loaded preset, changed settings, and Apply. Trace which preset name and shader format are selected at save time; done means Apply updates the loaded preset instead of saving as retroarch.slang, retroarch.glsl, or retroarch.cg.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- computer-graphics, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100