libretro / libretro/RetroArch

(Audio) Rewind with threaded audio

Open
#10,145 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug: audio distro: debian platform: linux
Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Description

When core announces that it supports threaded audio, retroarch switches to it and disables
rewind.

Expected behavior

Two-fold:

  1. When user enables rewind, disable threaded audio.
  2. Allow the core to tell that it's compatible with rewinding and threaded audio.
Actual behavior

Rewind is disabled with no way for user to enable it.

Steps to reproduce the bug
  1. Enable rewind
  2. Load a core with threaded audio
  3. Start the game
  4. Try to rewind
Bisect Results

This was added in f4a23115c24215271022d44dfc315b718131dad5

Version/Commit

You can find this information under Information/System Information

  • RetroArch: d36941b81df6180aa8535169fe7b5b3a569fa45a
Environment information
  • OS: Debian buster running inside chromeos container
  • Compiler: gcc version 8.3.0 (Debian 8.3.0-6)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing commit f4a23115c24215271022d44dfc315b718131dad5 and the rewind and threaded-audio handling it introduced; the issue names no files or tests. Reproduce the behavior with the listed steps, then verify that rewind and threaded audio interact according to the two expected behaviors.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
audio-video-rtc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.