libretro / libretro/RetroArch

(Menu) [Windows] Garbled filenames with Chinese characters

Open
#10,137 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: menu platform: windows
Dominant language
C
Stars
14.1k
Forks
2.2k
Avg merge
7h 35m
Merged PRs (30d)
51

Description

Description

Select a game with a Chinese filename in a playlist, select "Add to Favorites", and then run the game in the "Favorites" list. The prompt "File could not be loaded from the playlist" appears. Select "Information" in the "Ouick Menu", and you can see that "File path" has garbled characters.

Expected behavior

Games with Chinese filename can be added to favorites and run successfully.

Actual behavior

Games with Chinese filename can be successfully added to the collection, but cannot be run because "File path" becomes garbled. Prompt "File could not be loaded from the playlist".

Steps to reproduce the bug
  1. I have a playlist called "N64", and there is an N64 game called "塞尔达传说-时之笛(汉化版).zip"("The Legend of Zelda - Ocarina of Time (Chinese Version)") in the playlist.
  2. Select this game and then select "Run", the game can run successfully.
  3. Exit the game and select "Add to Favorites" in the "Ouick Menu".
  4. Navigate to the "Favorites" list, you can find this game, but it won't run, prompt "File could not be loaded from the playlist"
  5. Select the game in the "Favorites" list, then select "Information" in the "Ouick Menu", and find that "File path" becomes "塞尔达传�?时之�?汉化�? .zip"。

Game in the "N64" playlist:

Name: 塞尔达传说-时之笛(汉化版)
File path: D:\RetroArch\Roms\N64\塞尔达传说-时之笛(汉化版).zip

Game in the "Favourite":

Name: 塞尔达传说-时之笛(汉化版)
File path: D:\RetroArch\Roms\N64\塞尔达传�?时之�?汉化�? .zip

The Chinese "Name" is no problem, but the "File path" is garbled.

Bisect Results

During the process of adding from playlist to Favourite, did the file path undergo any conversion?

Version/Commit
  • RetroArch: 1.8.4 (Stable)
  • Build date: Jan 15 2020
  • Git version: f425d8dc8b
Environment information
  • OS: Windows 10 x64 Build 18362
  • Compiler: MinGW (9.2.0) 64-bit

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce on Windows with MinGW by comparing the playlist-to-Favorites path handling for the supplied Chinese filename; done means the path remains intact in Information and the game launches successfully from Favorites.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
frontend, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.