Scaling and button mapping (advanced settings) forgotten
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 37
- Forks
- 38
- PR merge metrics
- No merged PRs in 30d
Description
Version: 0.60 (Miyoo build)
Changes made in the "Advanced" section of the settings (scaling, button mapping) are correctly saved to the config file, but not loaded when PokeMini starts -- resulting in the changes made by the user being ignored/forgotten on next launch!
This isn't so critical for scaling, as that's an easy switch to have to manually make on startup, but for button mapping it does get quite annoying/tedious having to reconfigure the buttons every time.
Because the changes in these settings are being written to the config file correctly (I checked), it makes me think that there is either an omission/oversight or bug in the code when it comes to loading these settings on launch. Or that it is yet an incomplete feature in the software (missing an implementation). (I haven't had a look at the code yet.)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the configuration is loaded during PokeMini startup and compare it with the existing save path for Advanced settings, especially scaling and button mapping. Confirm the fix by changing those settings, restarting the Miyoo build, and verifying that both values are restored.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100