librelane / librelane/librelane

Incorrect DRC summary report

Open
#797 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🐞 bug
Dominant language
Python
Stars
543
Forks
105
Avg merge
5d 14h
Merged PRs (30d)
4

Description

Description

The summary report for IHP is not correct. It is not showing the partial area ratio, but instead shows the cumulative area ratio, which is what IHP uses.

Expected Behavior

The summary should correctly show the correct number to indicate the right number for showing what is leading to violation.

Environment report
kernel: Linux
kernel_version: 6.16.3-76061603-generic
supported: True
distro: pop
distro_version: 22.04
python_version: 3.12.11
python_path:
  - /nix/store/zx6xhps7vpg1h65hibki031g2gi4cx51-FABulous-env/bin
  - /nix/store/ph979qi76c0k0c59raqvg3m0636q9f9w-python3.12-librelane-3.0.0.dev40/lib/python3.12/site-packages
  - /nix/store/zx6xhps7vpg1h65hibki031g2gi4cx51-FABulous-env/lib/python3.12/site-packages
  - /home/kelvin/FABulous_fork.worktrees/gds-flow
  - /nix/store/l0ggvxyqck9v0npx95i9fw56p36rsz3y-python3-3.12.11/lib/python312.zip
  - /nix/store/l0ggvxyqck9v0npx95i9fw56p36rsz3y-python3-3.12.11/lib/python3.12
  - /nix/store/l0ggvxyqck9v0npx95i9fw56p36rsz3y-python3-3.12.11/lib/python3.12/lib-dynload
  - __editable__.fabulous_fpga-0.0.0.finder.__path_hook__
tkinter: True
container_info:
  engine: docker
  version: 28.5.1
  conmon: False
  rootless: False
  seccomp: False
  selinux: False
  apparmor: False
  path: /usr/bin/docker
nix_info:
  version_string: nix (Nix) 2.31.2
  channels:
    nixpkgs: https://nixos.org/channels/nixpkgs-unstable
  nix_command: True
  flakes: True
Reproduction material

41-openroad-checkantennas-1.zip

Relevant log output
in the step folder

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the attached 41-openroad-checkantennas-1.zip and reproduce the DRC summary in the step folder described in the log. Trace where the summary report obtains the area ratio and compare the displayed value with the partial ratio that indicates the violation. Done means the report shows the ratio relevant to the violating rule and the reproduction confirms the corrected output.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.