libredb / libredb/libredb-studio
Data Profiler shows the numeric icon on every column regardless of type
- Dominant language
- TypeScript
- Stars
- 726
- Forks
- 119
- Avg merge
- 7h 41m
- Merged PRs (30d)
- 284
Description
## What
The Data Profiler puts the numeric icon on every column profile, including text, boolean and date columns. The icon carries no information because it never varies.
## Where
src/components/DataProfiler.tsx:330, inside `profile.columns.map((col) => ...)`
```tsx
{col.name}
{col.type && {col.type}}
```
`Hash` is rendered unconditionally. `col.type` is already available on the same row, and the sensitive-column `Lock` icon two lines below shows the conditional pattern this file already uses.
## Expected
The icon reflects what the column holds, or it is dropped.
## How to fix
Either pick the icon from `col.type` (`Hash` for numeric, `Type` for text, `Calendar` for date and time, `ToggleLeft` for boolean, a neutral fallback otherwise), or remove the icon and let the type label carry the meaning. The second option is smaller and loses nothing.
## How to check
Profile a table with mixed column types and confirm the icons differ, or that no misleading icon is shown.
Contributor guide
Assessment
This issue has not been assessed yet.