libredb / libredb/libredb-studio
Login email and password inputs have no autoComplete attribute
- Dominant language
- TypeScript
- Stars
- 726
- Forks
- 119
- Avg merge
- 7h 47m
- Merged PRs (30d)
- 265
Description
## What
Neither credential field on the login page sets `autoComplete`, so password managers and browser autofill get no hint on the app's only sign-in form. Users fill both fields by hand every time.
## Where
`src/app/login/login-form.tsx`, the email input at line 303 and the password input just below it. Neither carries an `autoComplete` attribute.
The TOTP field further down the same file does set one, at line 350:
```tsx
autoComplete="one-time-code"
```
`ConnectionModal.tsx` is explicit on nine fields as well. The email and password pair is the one credential input in the app with no directive at all.
## Expected
The email field carries `autoComplete="username"` and the password field carries `autoComplete="current-password"`. Those are the values browsers and password managers look for on a sign-in form.
## How to fix
1. In `src/app/login/login-form.tsx`, add `autoComplete="username"` to the email `Input` at line 303.
2. Add `autoComplete="current-password"` to the password `Input` below it.
3. Change nothing else. The TOTP field at line 350 is already correct.
## How to check
Run `bun run dev` and open `/login`. Save a credential in the browser's password manager, reload, and confirm the browser offers to fill both fields.
Contributor guide
Research direction
Open src/app/login/login-form.tsx and inspect the email input around line 303, the password input below it, and the existing TOTP autocomplete at line 350. Add the two specified autocomplete directives without changing other fields, then run bun run dev and check /login with saved browser credentials to confirm both fields can be autofilled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication, frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 95/100