libpnet / libpnet/libpnet

Solving dependency problem against ipnetwork

Open
#758 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
2.6k
Forks
329
PR merge metrics
No merged PRs in 30d

Description

NetworkInterface::ip returns a type depending on ipnetwork::IpNetwork. This forces a crate using pnet to declare a dep on ipnetwork.
The options right now see to be:

  • depending on any version of ipnetwork, hoping pnet always use a compatible one (bad)
  • depending on the same version this version of pnet uses, which requires attention when switching to a newer pnet (arguably better, but not ideal)

OTOH, if pnet would just re-export IpNetwork as part of its own API, there would be no need for a cumbersome extra dependency.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating NetworkInterface::ip and the pnet dependency on ipnetwork. Check how the public type is exposed and how existing users consume it; done means pnet re-exports IpNetwork so callers no longer need a separate direct dependency.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.