Fix Docker build for js-v2.x
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 65
- Forks
- 82
- PR merge metrics
- No merged PRs in 30d
Description
## Problem
The Docker build for js-v2.x was failing with TypeScript compilation errors:
- `discoverRelays` property doesn't exist in `CircuitRelayTransportInit` type
- TypeScript configuration incompatibilities with aegir 47.0.16
## Solution
- Updated aegir from `^47.0.16` to `^47.0.22` to match js-v3.x (which builds successfully)
- Removed `discoverRelays: 1` parameter from `circuitRelayTransport()` call - this API was removed in @libp2p/circuit-relay-v2 v3.x, relay discovery is now automatic
- Updated package-lock.json to sync with new aegir version
## Changes
- `transport/impls/js/v2.x/package.json` - Updated aegir version
- `transport/impls/js/v2.x/package-lock.json` - Synced dependencies
- `transport/impls/js/v2.x/test/fixtures/get-libp2p.ts` - Removed deprecated discoverRelays parameter
The build now completes successfully.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with transport/impls/js/v2.x/package.json, package-lock.json, and test/fixtures/get-libp2p.ts, then inspect the reported TypeScript and Docker build failures. Done means the js-v2.x Docker build completes successfully with dependencies synchronized and no deprecated relay-discovery parameter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, javascript, typescript
- Domain
- build-system, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100