perf: rsync everything is brittle
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 65
- Forks
- 82
- PR merge metrics
- No merged PRs in 30d
Description
The runner syncs the current state of the directory to the EC2 instances: https://github.com/libp2p/test-plans/blob/0b4e5e490defc028670f3a5f977b350bc04282f3/perf/runner/src/index.ts#L217-L218
This means that if you've built the implementations locally, the binaries will be synced to the server as well. Apparently, these binaries aren't overwritten by the build process, leading to inconsistent state. And, if you're building on a different architecture, those binaries can't be executed.
Possible solutions: Be more careful what to sync to the server. One way to do that could be obtaining the list of files tracked by Git, and only syncing those. Or alternatively, exclude the files ignored by Git, or at the very least blacklist the build outputs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the sync entry point in perf/runner/src/index.ts at lines 217-218 and determine which local files are sent to the EC2 instances. Compare the sync behavior with Git-tracked or ignored files and choose a bounded approach. Done means locally built, architecture-specific binaries are no longer copied or executed on the server.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, git, typescript
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100