libp2p / libp2p/specs

identify: multiple Push messages are racy

Open
#501 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
1.8k
Forks
320
Avg merge
11d 15h
Merged PRs (30d)
1

Description

When a peer send multiple Identify push messages in succession, the outcome of this will be racy, since there's no ordering guarantee between the two Identify Push streams.

This can easily be solved by adding a sequence number to the Identify message.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by locating the Identify message specification and its push-stream ordering rules, then determine where successive messages are represented; done means the specification clearly defines behavior for multiple Identify pushes and the sequence-number requirement.

Written by the indexing model from the issue text.

Assessment

Domain
distributed-systems, networking
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.