libp2p / libp2p/specs

[Identify] How to integrate signed peer records?

Open
#347 13 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
1.8k
Forks
320
Avg merge
11d 15h
Merged PRs (30d)
1

Description

The /identify protocol was conceived before signed peer records were added.

Is there a plan of integrating signed peer records into /identify? I think there are a number of ways:

  1. Create /identify/1.1.0 where listenAddrs is deprecated and a new field listenPeerRecords is added.
  2. Create an entirely new protocol that is built on top of peer records instead of plain addresses and simply deprecate the old identify protocol.

(1) could be implemented in a backwards-compatible way where upgraded peers always populate both fields.
(2) could also be a good chance to do https://github.com/libp2p/specs/issues/45

Given the simplicity of the identify protocol, it might just be easier to design a completely new one. Nodes can always stay backwards compatible by supporting both protocols simultaneously.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the /identify protocol specification and the signed peer records design referenced in the issue. Compare the two proposed approaches, including the compatibility implications of /identify/1.1.0 and a new protocol, and review issue #45 for related scope. Done means the project has a decided integration design and an updated protocol specification.

Written by the indexing model from the issue text.

Assessment

Domain
distributed-systems, networking, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.