Rendezvous message signing
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 1.8k
- Forks
- 320
- Avg merge
- 11d 15h
- Merged PRs (30d)
- 1
Description
In the same way as we added message signing in Pubsub (https://github.com/ipfs/go-ipfs/issues/5383#issuecomment-413288002 + https://github.com/libp2p/go-libp2p-pubsub/pull/97), we should add message signing to our rendezvous register messages.
While we can guarantee that the addresses are authenticated through the Signed Peer Record, we cannot have guarantees that a malicious Rendezvous Point exists. Taking into account a discovery query for a given namespace, the signed peer records returned by the rendezvous point could be obtained from a registration to a different namespace, or just by crawling the network.
We will need to have a signature that also includes the namespace. Unfortunately, we cannot validate the ttl, but it would not be worth as the user could just unregister and the record would still be valid.
The easiest solution here would be signing the concatenation of a rendezvous prefix, the signed peer record bytes and the namespace. Its disadvantages are the extra signature creation, validation and size of the message.
cc Rendezvous Interest group @jacobheun @vyzo @daviddias @whyrusleeping @Stebalien @yusefnapora
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the Pubsub signing discussion in issue 5383 and go-libp2p-pubsub PR 97, then locate the rendezvous register message specification in this repository. Confirm how signed peer records and namespaces are represented. Done means the register-message design specifies signing that binds the record to the rendezvous namespace and explains validation.
Written by the indexing model from the issue text.
Assessment
- Domain
- networking, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100