libp2p / libp2p/rust-libp2p

Kad PUT_VALUE response deviating from the spec

Open
#6,217 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
5.6k
Forks
1.3k
Avg merge
8h 47m
Merged PRs (30d)
19

Description

Description

The spec says that a PUT_VALUE response message should have key and record fields set, however this implementaion does the following instead:

https://github.com/libp2p/rust-libp2p/blob/0125fa96b8de44ce3c3836a26339bfd9ba6db6fe/protocols/kad/src/protocol.rs#L326-L333

Motivation

It should follow the spec

Current Implementation

Uses key and value

Are you planning to do it yourself in a pull request?

Maybe

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in protocols/kad/src/protocol.rs at the linked lines and compare the PUT_VALUE response construction with the kad-dht RPC message specification. Update the response so its fields match the spec, using key and record rather than key and value; done means the implementation conforms to the cited response requirements.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.