libp2p / libp2p/rust-libp2p

Gosispsub - Cancel of Sending messages

Open
#5,751 1 comment 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
5.6k
Forks
1.3k
Avg merge
8h 47m
Merged PRs (30d)
19

Description

Description

There is a bit of talk about the recent IDONTWANT messages not being as effective as they could be.

People are noticing IDONTWANT messages being sent, but still being sent duplicates after. This indicates that nodes are currently sending queued messages, or are in the process of sending messages.

We can check some of these data points in Lighthouse to confirm. One improvement, could be to remove from the send queue any messages that have the ID of an IDONTWANT message we receive. Perhaps we could also drop the current send item, however, this might be difficult in practice with scoring and how the other end receives a half-sent message.

Motivation

Improve network bandwidth and reduce duplicates

Current Implementation

We have no mechanism of canceling messages once they are queued.

Are you planning to do it yourself in a pull request ?

Maybe

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing Gosispsub's handling of IDONTWANT messages and review the Lighthouse data points mentioned in the issue. Done means queued messages matching received IDONTWANT IDs are canceled, with the behavior of the currently sending item explicitly evaluated for safety.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.